Skip to content

chore(slo): refactor orphan summary cleanup task #245173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore(slo): refactor orphan summary cleanup task #245173

wants to merge 6 commits into from
+666 −624

Conversation

@kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Dec 3, 2025 •
edited
Loading

Summary

This PR refactors the SLO orphan summary cleanup task for better code organization and consistency with the other tasks, as well as fixing the abortController usage for allowing the task to be properly cancelled on timeout.

Testing

  • Create some SLOs with group by
  • Wait for the summary documents to be generated
  • Insert a dummy summary documents with a fake inexistant slo.id and revision (POST .slo-observability.summary-v3.5/_doc
  • Wait for the task to run (enable logging.logger for plugins.slo)
  • Confirm dummy summary document is gone
## LOGGER
logging:
  loggers:
    - name: plugins.slo
      level: debug

@github-actions github-actions bot added the author:actionable-obs PRs authored by the actionable obs team label Dec 3, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.3.0 backport:skip This PR does not require backporting labels Dec 3, 2025
@kdelemme kdelemme self-assigned this Dec 3, 2025
@kdelemme kdelemme added the ci:beta-faster-pr-build Uses an alternative PR build pipeline with speed optimizations label Dec 3, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #133 / task_manager check_registered_task_types should check changes on all registered task types
  • [job] [logs] FTR Configs #133 / task_manager check_registered_task_types should check changes on all registered task types

Metrics [docs]

✅ unchanged

History

cc @kdelemme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kdelemme kdelemme

Labels

author:actionable-obs PRs authored by the actionable obs team backport:skip This PR does not require backporting ci:beta-faster-pr-build Uses an alternative PR build pipeline with speed optimizations release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kdelemme @elasticmachine